Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix binja backend stack string detection #1663

Closed
wants to merge 2 commits into from
Closed

Fix binja backend stack string detection #1663

wants to merge 2 commits into from

Conversation

xusheng6
Copy link
Contributor

This fixes a bug in the binja stack string detection code.

I was writing the code with a newer version of binja. It does not work with the stable headless used for the CI.

Checklist

  • No CHANGELOG update needed
  • No new tests needed
  • No documentation update needed

@google-cla
Copy link

google-cla bot commented Jul 24, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@xusheng6
Copy link
Contributor Author

I will sign the CLA after discussing with the company

I also notice a rule linter failure for forwarded export. Although BN currently does not support forwarded export, I think this is not related, right?

@xusheng6
Copy link
Contributor Author

I am closing this and will create a new one

@xusheng6 xusheng6 closed this Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant