-
Notifications
You must be signed in to change notification settings - Fork 536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Statement construction for mixed-scope rules #1671
Merged
williballenthin
merged 12 commits into
mandiant:dynamic-feature-extraction
from
yelhamer:rule-statement-building
Aug 1, 2023
Merged
Statement construction for mixed-scope rules #1671
williballenthin
merged 12 commits into
mandiant:dynamic-feature-extraction
from
yelhamer:rule-statement-building
Aug 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yelhamer
added
breaking-change
introduces a breaking change that should be released in a major version
gsoc
Work related to Google Summer of Code project.
dynamic
related to dynamic analysis flavor
labels
Jul 27, 2023
williballenthin
requested changes
Aug 1, 2023
williballenthin
approved these changes
Aug 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks!
williballenthin
merged commit Aug 1, 2023
6192467
into
mandiant:dynamic-feature-extraction
15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking-change
introduces a breaking change that should be released in a major version
dynamic
related to dynamic analysis flavor
gsoc
Work related to Google Summer of Code project.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've made several assumptions in this PR that I've summarized in this issue: #1672 . If you disagree with any of the assumptions made, then please let me know!
Checklist