BinExport2 backend #1950
Merged
BinExport2 backend #1950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[wip] since there are a few references to BinExport2 that are in progress elsewhre. Next commit will remove them.
Co-authored-by: Moritz <[email protected]>
|
add BinExport tests
add pruning phase to expression tree building to remove known-bad branches. This might address some of the data we're seeing due to: NationalSecurityAgency/ghidra#6821 Also introduces a --instruction optional argument to dump the details of a specific instruction.
Introduce intruction pattern matching to declaratively describe the instructions and operands that we want to extract. While there's a bit more code, its much more thoroughly tested, and is less brittle than the prior if/else/if/else/if/else implementation.
|
I think there's only these now outstanding: Anything else before we can merge? |
Done with 765f434 |
mr-tz
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1755
This PR adds support for BinExport2 files generated via the Ghidra BinExport exporter extension. Supported file types include PE and ELF files, supported architectures include Intel 32- and 64-bit and ARM 64-bit. Support for additional BinExport exporters, file types, and architectures should be added as-needed following the merge of this PR.
TODO:
Android/ELF/arm32-- out of scope for nowAndroid/ELF/amd64-- out of scope for nowIDA Pro BinExport2-- out of scope for nowBinary Ninja BinExport2-- out of scope for nowChecklist