use new IDAPython 9.0 APIs

[mr-tz]

closes #2311

WIP as we need to figure out how to use 8.0 and 9.0 APIs

currently this should work just for IDA Pro 9.0 only though

Checklist

• No CHANGELOG update needed

• No new tests needed

• No documentation update needed

[williballenthin]

what?!? 🏃 so fast nice work

[williballenthin]

looks like we should introduce some wrappers that can switch on the IDA version. we can maintain those while we want to support 7/8/9 and then maybe deprecate them in a year or so?

i'm pleasantly surprised how small the delta is so this seems maintainable enough. thoughts?

[mike-hunhoff]

looks like we should introduce some wrappers that can switch on the IDA version. we can maintain those while we want to support 7/8/9 and then maybe deprecate them in a year or so?

i'm pleasantly surprised how small the delta is so this seems maintainable enough. thoughts?

I second this, a few wrappers should enable us to maintain compatibility across supported IDA versions.

[mr-tz]

yes, sounds good - luckily here we only use a few affected APIs

[mr-tz]

so something along those lines?!

def get_filetype() -> "filetype_t":
    version = float(idaapi.get_kernel_version())
    if version < 9.0:
        file_info = idaapi.get_inf_structure()
        return file_info.filetype
    else:
        import ida_ida
        return ida_ida.inf_get_filetype()

[williballenthin]

I would recommend doing the version check at the top level of the Python module and defining the functions within the if/else blocks, so that the cost of the version check is O(1) at import-time versus O(#api calls) at runtime. Something like:

version = float(idaapi.get_kernel_version())
if version < 9.0:
    def get_filetype() -> "filetype_t":
        file_info = idaapi.get_inf_structure()
        return file_info.filetype

else:
    import ida_ida
    def get_filetype() -> "filetype_t":
        return ida_ida.inf_get_filetype()

[mike-hunhoff]

Looking good 🚀