Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for WHOIS command on IRCListener #159

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions fakenet/listeners/IRCListener.py
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,15 @@ def start(self):
self.server.config = self.config
self.server.servername = self.config.get('servername', 'localhost')

if self.server.servername.startswith('!'):
self.server.servername = self.server.servername[1:]
if self.server.servername.lower() == "random":
self.server.servername = self.randomizeHostname()
elif self.server.servername.lower() == "gethostname":
self.server.servername = socket.gethostname()
else:
raise ValueError('ServerName config invalid escape: !%s' % (servername))

self.server_thread = threading.Thread(target=self.server.serve_forever)
self.server_thread.daemon = True
self.server_thread.start()
Expand Down Expand Up @@ -159,6 +168,12 @@ def irc_DEFAULT(self, cmd, params):
self.server.logger.info('Client issued an unknown command %s %s', cmd, params)
self.irc_send_server("421", "%s :Unknown command" % cmd)

def irc_WHOIS(self, cmd, params):
output = f"{self.nick} {self.user} {self.server.servername} * {self.realname}"
self.irc_send_server("311", output)
self.server.logger.info("Client has issued WHOIS command: " + output)
self.irc_send_server("318", "%s :End of /WHOIS list" % self.nick)

def irc_NICK(self, cmd, params):

self.nick = params
Expand Down
14 changes: 13 additions & 1 deletion test/test.py
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,9 @@ def _irc_evt_handler(self, srv, evt):
if (evt.arguments[0].startswith(self.black_market) and
evt.target == self.pub_chan):
self.pubmsg_ok = True
elif evt.type == "whois":
if (evt.arguments[0].startswith(self.nick)):
self.whois_ok = True

def _irc_script(self, srv):
"""Callback manages individual test cases for IRC."""
Expand All @@ -137,12 +140,14 @@ def _irc_script(self, srv):
self.join_ok = False
self.privmsg_ok = False
self.pubmsg_ok = False
self.whois_ok = False

# This handler should set the success flags in success cases
srv.add_global_handler('join', self._irc_evt_handler)
srv.add_global_handler('welcome', self._irc_evt_handler)
srv.add_global_handler('privmsg', self._irc_evt_handler)
srv.add_global_handler('pubmsg', self._irc_evt_handler)
srv.add_global_handler('whois', self._irc_evt_handler)

# Issue all commands, indirectly invoking the event handler for each
# flag
Expand All @@ -156,6 +161,9 @@ def _irc_script(self, srv):
srv.privmsg(self.clouseau, self.safehouse)
srv.process_data()

srv.whois([self.clouseau])
srv.process_data()

srv.quit()
srv.process_data()

Expand All @@ -171,11 +179,15 @@ def _irc_script(self, srv):
if not self.pubmsg_ok:
raise FakeNetTestException('pubmsg test failed')

if not self.whois_ok:
raise FakeNetTestException('whois test failed')

return all([
self.welcome_ok,
self.join_ok,
self.privmsg_ok,
self.pubmsg_ok
self.pubmsg_ok,
self.whois_ok
])

def _run_irc_script(self, nm, callback):
Expand Down