Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Play JSON 2.5.2, add “updateAs” method #15

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

stanch
Copy link
Contributor

@stanch stanch commented Apr 28, 2016

This includes two commits from @MountVacation to update the version of Play JSON.

@stanch
Copy link
Contributor Author

stanch commented Dec 5, 2016

Just realized that my last commit on master also went into this PR, so now it’s not mergeable. Let me know if you want to merge, then I can remove it. But in the meantime I’ve published my fork to my own Bintray repo.

@mandubian
Copy link
Owner

Github tells me I can merge it...
What is the problem?

@stanch
Copy link
Contributor Author

stanch commented Dec 5, 2016

The problem is that it now has a commit where I changed the publishing setup :)

@stanch
Copy link
Contributor Author

stanch commented Dec 5, 2016

I am happy to remove that commit if you are willing to merge and publish yourself :)

@mandubian
Copy link
Owner

tell me what you prefer me to do, I'm not using the zipper anymore, so you're the lead now ;)

@stanch
Copy link
Contributor Author

stanch commented Dec 5, 2016

I suppose I can maintain it in my fork since we are using it at work :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants