Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mangareader] fixed CSS queries, migrated to new API #2181

Merged
merged 2 commits into from
Aug 15, 2020
Merged

[mangareader] fixed CSS queries, migrated to new API #2181

merged 2 commits into from
Aug 15, 2020

Conversation

ronny1982
Copy link
Contributor

return data.map(element => {
return {
id: this.getRootRelativeOrAbsoluteLink(element, this.url),
title: element.closest('td').textContent.replace(manga.title, '').trim(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May want to remove the trailing ":" when there is no chapter title.
title: element.closest('td').textContent.replace(manga.title, '').trim().replace(/:+$/, ""),

Copy link
Contributor

@Sheepux Sheepux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM
Suggesting minor improvement

@ronny1982 ronny1982 merged commit 1339ec1 into manga-download:master Aug 15, 2020
@ronny1982 ronny1982 deleted the mangareader branch August 15, 2020 13:53
ronny1982 added a commit that referenced this pull request Aug 15, 2020
* [mangareader] fixed CSS queries, migrated to new API

* [mangareader] remove trailing colon from chapter name
ronny1982 added a commit that referenced this pull request Aug 15, 2020
* [funlist] added website support (#2162)

* [mangas] fixed mangalist update (#2172)

* [doujindesu] replace archive with reader website (#2173)

* [mangalek] fixed manga list retrieval (#2175)

* [neoxscan] updated domain and icon (#2176)

* [mangakid] bypass ad-link protection (#2177)

* [kuragebunch] fixed path for manga list (#2178)

* [kissmanga] removed website support (#2184)

* [kissanime] removed website support (#2184)

* [mangareader] fixed CSS queries, migrated to new API (#2181)

* [kumanga] general overhaul of all issues, updated to new API (#2185)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants