Skip to content

Commit

Permalink
Remove jupyterlab 2 python 3.6 tests
Browse files Browse the repository at this point in the history
  • Loading branch information
manics committed Feb 9, 2024
1 parent 127623b commit febbfee
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 19 deletions.
13 changes: 2 additions & 11 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -72,15 +72,9 @@ jobs:
fail-fast: false
matrix:
include:
- python-version: '3.6'
jupyterlab-major: '2'
ubuntu: '20.04'
node: '16.x'
- python-version: '3.8'
jupyterlab-major: '3'
ubuntu: '22.04'
node: '18.x'
runs-on: ubuntu-${{ matrix.ubuntu }}
runs-on: ubuntu-22.04
# Includes geckdriver and firefox
# https://github.com/actions/virtual-environments/blob/main/images/linux/Ubuntu1804-README.md
steps:
Expand All @@ -95,7 +89,7 @@ jobs:

- uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node }}
node-version: '18.x'
cache: yarn

- name: Download artifacts from build
Expand All @@ -107,9 +101,6 @@ jobs:
- name: Install plugin
run: |
python -mpip install dist/*.whl
if [[ ${{ matrix.jupyterlab-major }} = 2 ]]; then
jupyter labextension install --debug --minimize=False ./jsdist/jupyter-offlinenotebook-jlpmpack.tgz
fi
- name: Run pytest
run: pytest -vs tests
Expand Down
2 changes: 0 additions & 2 deletions dev-requirements-jl2.old

This file was deleted.

13 changes: 7 additions & 6 deletions dev-requirements.txt
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
jupyter_packaging==0.7.12
jupyter_packaging==0.12.3
flaky==3.7.0
notebook==6.4.10
pre-commit==2.17.0
pytest==7.0.1
selenium==3.141.0
wheel==0.37.1
notebook==6.5.4
pre-commit==2.21.0
pytest==7.4.4
selenium==4.11.2
traitlets==5.9.0
wheel==0.42.0
# jupyterlab is installed separately so we can test multiple versions

0 comments on commit febbfee

Please sign in to comment.