https://github.com/manifold-systems/manifold-ij/issues/40

- close connection after failed init
manifold-systems · Jun 29, 2024 · cedce98 · cedce98
1 parent 95e1662
commit cedce98
Showing 1 changed file with 9 additions and 2 deletions.
diff --git a/...s-parent/manifold-sql-rt/src/main/java/manifold/sql/rt/impl/HikariConnectionProvider.java b/...s-parent/manifold-sql-rt/src/main/java/manifold/sql/rt/impl/HikariConnectionProvider.java
@@ -79,11 +79,18 @@ public Connection getConnection( String configName, Class<?> classContext )
   @Override
   public Connection getConnection( DbConfig dbConfig ) throws SQLException
   {
-    //noinspection resource
     HikariDataSource ds = _dataSources.computeIfAbsent( dbConfig.getName(), __ ->
       makeDataSource( dbConfig, dbConfig.getBuildUrlOtherwiseRuntimeUrl() ) );
     Connection connection = ds.getConnection();
-    dbConfig.init( connection, Compiler );
+    try
+    {
+      dbConfig.init( connection, Compiler );
+    }
+    catch( Throwable t )
+    {
+      connection.close();
+      throw t;
+    }
     return connection;
   }