-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New watermark on SVG graphs. #2776
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
@tarehart is attempting to deploy a commit to the Manifold Markets Team on Vercel. A member of the Team first needs to authorize it. |
Hard for me to guess why dev failed deployment, could someone please provide logs? |
It was a flaky error for our /stats page, which is unrelated! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call, that example scribbled it out worse than I imagined. Philosophically I think the data should take priority, but I guess we could explore putting the watermark left of the time range controls so they never conflict, does that sound good? |
It'll take me a while to experiment with a watermark near the time range controls since there are a bunch of code paths to change and test, and I'm a little less confident about what would look good. Might be a week before I make time. Should we consider merging this in the meantime as an incremental improvement? |
Side note, as an outside contributor with no GOOGLE_APPLICATION_CREDENTIALS_DEV, it's hard to test the contract page. I've resorted to temporarily using a regular db here rather than an adminDb: manifold/web/pages/[username]/[contractSlug].tsx Lines 96 to 97 in 8d62a25
What's the reason for this distinction, and is adminDb actually needed for the contract page, which appears to be read only? |
Looking at the mobile dimensions again, I'm skeptical that I can make the alternative placement look good in the available space. I think this change as it stands is a clear improvement, and I suggest merging it. The people suffer https://discord.com/channels/915138780216823849/1269095533956563014/1280347805101326429 |
Updating the watermark:
Related suggestions in discord:
There's another file, probability-needle.tsx, that has the old watermark; I haven't touched it because I think it looks fine on the probability needle.