Skip to content

Commit

Permalink
fix(config): remove no-longer-resolving rules
Browse files Browse the repository at this point in the history
  • Loading branch information
maninak committed Dec 15, 2023
1 parent 79ce5e6 commit eae6952
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 4 deletions.
3 changes: 3 additions & 0 deletions .vscode/settings.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,4 +28,7 @@
"jsonc",
"yaml",
],
"conventionalCommits.scopes": [
"config"
],
}
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
"postpublish": "git push --tags"
},
"dependencies": {
"@antfu/eslint-config": "^2.0.0",
"@antfu/eslint-config": "~2.0.0",
"@eslint/eslintrc": "^2.1.3",
"eslint": "^8.54.0",
"eslint-config-prettier": "^9.0.0",
Expand Down
2 changes: 1 addition & 1 deletion pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 4 additions & 2 deletions src/config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,8 @@ export default [
'max-statements-per-line': 'warn',
'no-empty': ['warn', { allowEmptyCatch: true }],
'no-multiple-empty-lines': ['warn', { max: 1, maxBOF: 0, maxEOF: 1 }],
'no-useless-return': 'warn',
'no-undef-init': 'warn',

/*
* Rules implemented by `eslint-plugin-unused-imports` follow
Expand All @@ -227,7 +229,7 @@ export default [
'antfu/if-newline': 'warn',
'antfu/import-dedupe': 'warn',
'antfu/top-level-function': 'warn',
'antfu/generic-spacing': 'warn',
// 'antfu/generic-spacing': 'warn', // TODO: maninak uncomment and find out why this no longer resolves

/*
* Rules implemented by `eslint-plugin-react` follow
Expand Down Expand Up @@ -275,7 +277,7 @@ export default [
files: [...GLOB_TESTS],
rules: {
// overrides to antfu's config follow
'no-only-tests/no-only-tests': 'warn',
// 'no-only-tests/no-only-tests': 'warn', // TODO: maninak uncomment and find out why this no longer resolves
},
},
{
Expand Down

0 comments on commit eae6952

Please sign in to comment.