Update and rename shared.lua to discord_muter.lua #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Namespace issue with shared.lua and other addons. Renaming fixes them. "Include" should be only Serverside as it throws errors on clientside as they cant open / dont need these luafiles.
|
Just maintain your own fork, there was a new Version in work 3 years ago in a Private Beta Discord, but the people wen away. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Namespace issue with shared.lua. Other addons using the same name will overwrite the file causing the addon not to work at all.
"Include" should be only Serverside as it throws errors on clientside as they cant open / dont need these luafiles. Not doing it serverside only causes 4x errors each time the files is loaded:
[ERROR] Couldn't include file 'discord\utils\logging.lua' - File not found or is empty
[ERROR] Couldn't include file 'discord\utils\messaging.lua' - File not found or is empty
[ERROR] Couldn't include file 'discord\utils\discord_connection.lua' - File not found or is empty
[ERROR] Couldn't include file 'discord\utils\http.lua' - File not found or is empty