Test a pr. #1
Open
Test a pr. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.hasNext() on the downsampler instead of letting it build a giant exception string that we're just tossing in the bit bucket.
exception causes.
class so they can be shared elsewhere. Also make queries a tiny bit more efficient with salting by compiling the row key regex once instead of once for each bucket.
…erly handle salted tables.
to to @Dieken for his work on the salting patch.
with pre 0.96 region servers.
instead of AsyncHBase.
Some browsers (aka firefox) like to encode { and } as %7B and %7D. This
causes problem when parsing the query string since its using { and } to
figure out the metric and tags. Without this the UI thows an error like
the following:
Request failed: Bad Request: No such name for 'metrics': 'server.nic.usage.mbit%7Bhost=host1%7D'
MetaScanner extracts (salt_width + metric_width) bytes from tsuid to metric uid, this triggers IllegalArgumentException in UniqueId.getNameAsync(id), then MetaScanner.call() won't never call result.callback(null), and result.joinUninterruptibly() in MetaSync.run() never returns. BTW, I checked all usages of Const.SALT_WIDTH() and fixed some other similar wrong calculations.
getBoolean function to parse various types of boolean setting flags.
Also make sure both versions of next() handle booleans.
destination directory. Thanks @shyamraj242.
Signed-off-by: Chris Larsen <[email protected]>
added /usr/lib/jvm/java-8-oracle in JDK_DIRS ...if JAVA_HOME is not defined in $DEFAULT Signed-off-by: Chris Larsen <[email protected]>
Signed-off-by: Chris Larsen <[email protected]>
Fix OpenTSDB#708 by using better comparisons The implemented Comparable interface was very inconsistent, leading to randomly sorted lists.
…lizing so that we skip any that do not start within the query timespan.
…byte methods in the UID class. This should properly decode the UTF strings now. Also remove the CHARSET from the UID class, use Const instead.
… before passing parameters to Gnuplot. Metrics and tags are already handled by the char list. Thanks @gsocgsoc
Annotations) so that plugins can extend them as needed. This can be useful in the search plugin.
manolama
force-pushed
the
master
branch
2 times, most recently
from
d3c0325
to
a7470fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.