-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nearby.html #884
Open
akshitbansal2005
wants to merge
2
commits into
mansiruhil13:main
Choose a base branch
from
akshitbansal2005:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
nearby.html #884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. **Meta Tags & SEO**: - **Issue**: Outdated `X-UA-Compatible` tag for IE; missing `meta` description for SEO. - **Fix**: Remove the `X-UA-Compatible` tag and add a relevant `meta description`. 2. **Favicon and Asset Path**: - **Issue**: Favicon is not placed in an organized asset folder. - **Fix**: Move to a proper directory like `src/images/` for better project structure. 3. **CSS Structure**: - **Issue**: Inline styles are present, and redundant font sizes exist in media queries. - **Fix**: Move all styles to external CSS for maintainability; streamline media queries. 4. **Accessibility**: - **Issue**: Icons and navigation lack ARIA labels for screen readers. - **Fix**: Add `aria-label` attributes to improve accessibility. 5. **File Naming Consistency**: - **Issue**: Mixed capitalization in filenames (`Feedback.html` vs. `feedback.html`). - **Fix**: Ensure consistent lowercase file naming for convention. 6. **Performance**: - **Issue**: FontAwesome library loads the entire set; no lazy-loading of heavy assets. - **Fix**: Load only necessary icons for performance boost.
1. **Head Section**: - Basic metadata is included (`<meta charset="UTF-8">`, `<meta name="viewport" content="width=device-width, initial-scale=1.0">`) to ensure compatibility across devices. - The page title is set to "Find Nearby Hospital." - A Google Translate widget script is loaded (`gtranslateSettings`) for multilingual support. 2. **CSS Styling**: - The CSS styles are embedded directly in the `<style>` tag. - A clean, minimal design is used, with a focus on readability, a grid layout for hospital cards, and hover effects. - The page uses a **grid layout** to display the hospitals in a responsive 4-column grid. - Cards (`.hospital-card`) include transitions for hover effects, giving them a slight zoom and shadow effect when the user interacts with them. - Fonts are set using a sans-serif family, and a light background (`#f7f7f7`) ensures easy readability. 3. **Body Section**: - Contains a title (`<h1>Find Nearby Hospital`) and a subtitle (`<h2>Track or call an ambulance and check nearby hospitals for emergency services`). - The hospital details are displayed as a series of **hospital cards** in a grid. - Each card has: - An **image** of the hospital. - The hospital **name** (clickable link opening the hospital's Google Maps location in a new tab). - A **location** description for easy identification. - The hospitals range from AIIMS Delhi to Venkateshwar Hospital. 4. **Hospital Data**: - Each hospital is represented by an image, a clickable name, and its location. - The Google Maps links are predefined, allowing users to find directions to each hospital quickly.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
👋 Thank you for opening this pull request! We're excited to review your contribution. Please give us a moment, and we'll get back to you shortly! Feel free to join our community on Discord to discuss more! |
output? screenshot? |
issue no.? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Head Section:
<meta charset="UTF-8">
,<meta name="viewport" content="width=device-width, initial-scale=1.0">
) to ensure compatibility across devices.gtranslateSettings
) for multilingual support.CSS Styling:
<style>
tag..hospital-card
) include transitions for hover effects, giving them a slight zoom and shadow effect when the user interacts with them.#f7f7f7
) ensures easy readability.Body Section:
<h1>Find Nearby Hospital
) and a subtitle (<h2>Track or call an ambulance and check nearby hospitals for emergency services
).Hospital Data: