2348 Pyright

[JackEAllen]

Issue

Closes #2348

Description

Add a description of the changes made.

• Add pyright as a dependancy to the project
• Add Pyright to conda and windows workflows
• Add Pyright pre-commit check to project
• Configure basic ruleset so Pyright does not initially overwhelm us with too many warnings
• Resolve some of the basic Pyright issues blagged up in the basic configuration to get us started with refactorign the project to be Pyright compliant.

This PR once merged in, provides a good starting point to begin disabling rules currently set to false within pyproject.toml to eventually allow for the typeChecking mode to be increased from "basic" to "Standard" and eventually to "strict".

Testing

Describe the tests that were used to verify your changes.

• Tested workflows fail if Pyright issues exist within the project
• Tested pre-commit fails if Pyright issues exist in any staged files.
• Tested Mantid Imaging basic Workflows
• Ran unit tests

Acceptance Criteria

How should the reviewer test your changes?

• Rebuilding a developer environmnet inlcudes Pyright in the list of dependancies
• Conda and Windows Pyright workflows will fail if a Pyright issue exists in the project
• Pyright pre-commit check will block a commit if any of the staged files do not pass Pyright checks
• Mantid Imaging still performs as expected:
  • Run through operations, reconstructions and test spectrum viewer all still work as expected.

Documentation

How have you changed the documentation to reflect your changes? All changes should be noted in the appropriate file in docs/release_notes

See docs/release_notes/next/dev-2348-Pyright

[coveralls]

coverage: 74.22% (-0.04%) from 74.259%
when pulling 3b1c28f on 2348_pyright
into fa4fb94 on main.

[samtygier-stfc]

Thanks. A good set of improvements.