Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Live Viewer Intensity Plot recalculates when images modified #2491

Merged
merged 4 commits into from
Feb 20, 2025

Conversation

MikeSullivan7
Copy link
Collaborator

@MikeSullivan7 MikeSullivan7 commented Feb 3, 2025

Issue Closes #2490

Description

The Live Viewer now keeps track of the Updated Image List and compares it to the new Image List when changes are made in the directory. This allows the LV to detect if more than one image has appeared at a time, or if any number of images have been deleted and recalculate the mean if this has happened. The update_image_list() method in the presenter is now put on a QTimer as when a large number of images are deleted or changed, it can take long enough that update_image_list() could be triggered multiple times in short succession which lead to peoples with the QThreads.

Developer Testing

make check
make test-system

Acceptance Criteria and Reviewer Testing

  • Unit tests pass locally: python -m pytest -vs
  • Open the LV with some images in the directory
  • Add and delete images of various quantities in the directory and check that the Intensity Plot updates accordingly.

Documentation and Additional Notes

  • Release Notes have been updated

@MikeSullivan7 MikeSullivan7 self-assigned this Feb 3, 2025
@MikeSullivan7 MikeSullivan7 force-pushed the 2490_LV_images_modified_intensity_plot branch from fe94c8d to 8ab42d9 Compare February 3, 2025 12:58
@coveralls
Copy link

coveralls commented Feb 4, 2025

Coverage Status

coverage: 72.627% (-0.02%) from 72.645%
when pulling bda5df1 on 2490_LV_images_modified_intensity_plot
into fa2343c on main.

@MikeSullivan7 MikeSullivan7 force-pushed the 2490_LV_images_modified_intensity_plot branch 2 times, most recently from d896622 to a1e7a24 Compare February 12, 2025 15:33
@MikeSullivan7 MikeSullivan7 marked this pull request as ready for review February 13, 2025 12:23
@MikeSullivan7 MikeSullivan7 force-pushed the 2490_LV_images_modified_intensity_plot branch from 6b1965a to af84228 Compare February 20, 2025 12:36
@MikeSullivan7 MikeSullivan7 force-pushed the 2490_LV_images_modified_intensity_plot branch from af84228 to bda5df1 Compare February 20, 2025 16:56
Copy link
Collaborator

@samtygier-stfc samtygier-stfc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and seem robust in my testing on linux

@samtygier-stfc samtygier-stfc added this pull request to the merge queue Feb 20, 2025
Merged via the queue into main with commit dd7bcf3 Feb 20, 2025
8 checks passed
@samtygier-stfc samtygier-stfc deleted the 2490_LV_images_modified_intensity_plot branch February 20, 2025 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle images arriving simultaneously and images being deleted in Live Viewer (Intensity Plot)
3 participants