Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Pill RTL styles #5782

Closed
wants to merge 1 commit into from
Closed

Fix Pill RTL styles #5782

wants to merge 1 commit into from

Conversation

rilrom
Copy link
Contributor

@rilrom rilrom commented Feb 17, 2024

Fixes #5779.

I've noticed padding-inline-* is not used much throughout the codebase, please let me know if you would prefer to continue using the @mixin where-rtl approach and I can adjust.

@rilrom rilrom changed the title fix Pill RTL styles Fix Pill RTL styles Feb 17, 2024
AlonMiz
AlonMiz approved these changes Feb 17, 2024
View reviewed changes
Copy link

@AlonMiz AlonMiz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beautiful, makes much more sense then deciding left & right on each mode

@rtivital
Copy link
Member

Thanks for submitting a PR, the issue has already been fixed in 7.6.0

@rtivital rtivital closed this Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlonMiz AlonMiz AlonMiz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pills with remove button are not compatible with RTL
3 participants
@rilrom @rtivital @AlonMiz