Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@mantine/docs] Radarchart: Fix demo codes #5894

Merged
merged 2 commits into from
Mar 12, 2024

Conversation

Kenzo-Wada
Copy link
Contributor

@Kenzo-Wada Kenzo-Wada commented Mar 8, 2024

What I did

  • fixed imports of demo codes of Radarchart
    • data -> multiData
  • fixed some layouts of code(blank line, component name)

@@ -5,7 +5,7 @@ import { multiData, multiDataCode } from './_data';

const code = `
import { RadarChart } from '@mantine/charts';
import { data } from './data';
import { multiData } from './data';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not correct fix, it should be renamed on line 14 instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the review!

fixed it: be3e615

@Kenzo-Wada Kenzo-Wada requested a review from rtivital March 9, 2024 03:49
@rtivital rtivital merged commit bf0b64f into mantinedev:master Mar 12, 2024
1 check passed
@rtivital
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants