[@mantine/core] TagsInput: Fix incorrect IME keyboard input handling for Backspace (#6010)
#6011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
Before fix demo check #6010 . After fix demo: tagsinput-ime-no-bug.mp4 |
…for `Backspace` (mantinedev#6010) When people use IME to type in CJK words, a `Backspace` key would delete both a char in the CJK words and the previous tag before this fix. Ref PR: mantinedev#4947
xiaohanyu
force-pushed
the
fix/tagsinput-ime-backspace
branch
from
2dc0e39 to
0309c19
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When people use IME to type in CJK words, a
Backspacekey would delete both a char in the CJK words and the previous tag before this fix.Ref PR: #4947