Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple database driver adaptations to do list #4

Open
2 of 6 tasks
manyuanrong opened this issue Dec 27, 2019 · 6 comments · May be fixed by #38
Open
2 of 6 tasks

Multiple database driver adaptations to do list #4

manyuanrong opened this issue Dec 27, 2019 · 6 comments · May be fixed by #38
Assignees
@tksilicon
Labels
enhancement New feature or request

Comments

@manyuanrong
Copy link
Owner

manyuanrong commented Dec 27, 2019 •
edited
Loading

In order to achieve multiple database driven adaptation, we need to implement the following

  • src/drivers/base.ts Unified interface definition
  • src/drivers/mysql.ts MySQL adapter based on base.ts
  • src/drivers/postgres.ts Postgres adapter based on base.ts
  • src/dso.ts Do not import any driver, dynamically import the driver through the parameter of connect
  • mysql.ts At the same level as mod.ts, the export directly imports dso of MySQL driver
  • postgres.ts At the same level as mod.ts, the export directly imports dso of Postgress driver
@manyuanrong manyuanrong mentioned this issue Dec 27, 2019
Open
@evnix
Copy link

evnix commented May 17, 2020

This would be amazing!

@manyuanrong manyuanrong pinned this issue May 17, 2020
@tksilicon
Copy link
Collaborator

tksilicon commented Jul 7, 2020 •
edited
Loading

Do you have anything you have done, so I can take it from there, you can share the code in a feature branch if you wouldn't commit on master so I can finish it? @manyuanrong?

@manyuanrong
Copy link
Owner Author

@tksilicon The items in the todo list are still not in progress. If you want, I can add you as a collaborator.

@tksilicon
Copy link
Collaborator

You can @manyuanrong. This issue can be resolved in a week or two. I very much am interested in this project. It has been a learning opportunity for me.

@manyuanrong
Copy link
Owner Author

@tksilicon I have sent an invitation. I hope to do this work on a new branch and finally merge into master

@tksilicon
Copy link
Collaborator

Definitely. It will be a new branch by me to merge into master by you. @manyuanrong

@tksilicon tksilicon self-assigned this Jul 15, 2020
@tksilicon tksilicon added the enhancement New feature or request label Jul 15, 2020
This was referenced Aug 4, 2020
Closed
Closed
Open
@tksilicon tksilicon linked a pull request Nov 5, 2020 that will close this issue
Database driver adaptations mysql #38
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tksilicon tksilicon

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Database driver adaptations mysql manyuanrong/dso
3 participants
@evnix @tksilicon @manyuanrong