Database driver adaptations mysql #38
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat:databaseDriverAdaptations - MySQL feat:databaseDriverAdaptations - MySQL feat:databaseDriverAdaptations - MySQL feat:databaseDriverAdaptations - MySQL feat:databaseDriverAdaptations - MySQL feat:databaseDriverAdaptations - MySQL feat:databaseDriverAdaptations - MySQL feat:databaseDriverAdaptations - MySQL feat:databaseDriverAdaptations - MySQL feat:databaseDriverAdaptations - MySQL feat:databaseDriverAdaptations - MySQL
tksilicon
force-pushed
the
databaseDriverAdaptations-mysql
branch
from
da918d5 to
aa019fa
Compare
feat:databaseDriverAdaptations - MySQL feat:databaseDriverAdaptations - MySQL feat:databaseDriverAdaptations - MySQL
tksilicon
force-pushed
the
databaseDriverAdaptations-mysql
branch
from
aa019fa to
6e90cab
Compare
6 tasks
|
I made some modifications on this basis.
|
|
And the dependency of mysql is placed in drivers/mysql.ts. Because in the future, driver/mysql will use dynamic import to avoid loading these dependencies when I use the postgres database. |
|
@tksilicon You can try to implement other drivers on this basis. Let's at least finish postgres |
Will do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented MysqlClient based on the discussions of #32. Incorporated as much changes as I could. Take a look at it @manyuanrong. Other clients would be implemented if okay.