Server is now http2 + Allow resize based on height #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… 0 + allow options without resizing
jdeniau
approved these changes
May 31, 2024
|
|
||
| $baseUrl = '//img.mapado.net/2014/1/1/my-image'; | ||
| $url = $this->manager->buildUrl($baseUrl, 0, 200); | ||
| $this->assertSame($baseUrl . '_thumbs/0-200', $url); |
There was a problem hiding this comment.
Can you add a test with null and null for width and height ? and another one with ['allowwebp' => true] ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nouveau comportement
Les nouveaux serveurs d'image sont http2.
Grace au multiplexage apporté par http2, on n'a plus besoin de séparer les calls sur le serveur (entre img.mapado.net et img1.mapado.net)
Par ailleurs, on permet à présent un redimensionnement basé sur une hauteur (et pas seulement une largeur), ce qui est particulièrement pratique pour un logo affiché sur une ligne dont on connait la hauteur, mais dont la largeur peut varier.
Tache Clickup
🧑🔧