Prefer prettier over Symfony style #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdeniau
force-pushed
the
use-prettier-version-instead-of-symfony
branch
from
156a6d3 to
f6284be
Compare
lnahiro
approved these changes
Aug 29, 2024
JulienRAVIA
approved these changes
Aug 29, 2024
Comment on lines
+128
to
+131
| 'operator_linebreak' => [ | ||
| 'only_booleans' => true, | ||
| 'position' => 'end', | ||
| ], |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actuellement on a un conflit entre prettier et php-cs-fixer (en particulier avec la définition de Symfony), et on se retrouve souvent avec des diffs comme ça
et comme ça :
Dès qu'on enregistre un fichier et qu'on passe prettier dessus.
Pour le premier screen, le soucis vient d'un problème de prettier : prettier/plugin-php#2400
Pour le second, c'est que prettier est opiniatre, et que la PER n'impose rien dans ce sens, donc ils se rangent du côté de prettier JS pour faire le formatage.
Perso je préfère les
&&en début de ligne, mais je trouve le soucis de cohérence bien plus embêtant, donc je me range du côté de prettier.