Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small mapbase fixes #322

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Commits on Sep 5, 2024

  1. Implement GetColorForSurface() failure workaround

    This function is used to color impact particles.
    On Linux I've noticed that this function sometimes is not successful on
    retrieving the surface color, leaving an odd color to render the
    particles with. The engine function TraceLineMaterialAndLighting() even
    has a boolean return value indicating success.
    GetModelMaterialColorAndLighting() does not though, but I still observe
    failures (the color parameter is not modified). The color is initialized
    with an invalid value. If it detects that retrieving the color failed
    (engine function said so or the invalid value was left in place), this
    now hamfistedly assumes a lightish grey color, but at least still
    correctly (presumably) incorporates lighting information.
    When this situation is detected, a warning is also printed to the
    console. Because why not.
    z33ky committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    e9c45e5 View commit details
    Browse the repository at this point in the history
  2. Fix -Wdelete-incomplete in CDefaultCustomWeaponEntityFactory::Release…

    …Data()
    
    GCC warns about attempting to delete a void-pointer, since it will not
    be able to invoke its destructor. Fix by casing it to the expected
    type.
    z33ky committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    df6adcc View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a999c79 View commit details
    Browse the repository at this point in the history
  4. Ditch attempts trying to obtain sound duration of MP3s

    Crashes on Linux. Apparently returns incorrect values on Windows.
    z33ky committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    359fcb7 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2024

  1. Configuration menu
    Copy the full SHA
    6960362 View commit details
    Browse the repository at this point in the history