Make destination annotation methods public #4253
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kried
reviewed
Dec 8, 2022
kried
force-pushed
the
jill/NAVIOS-678-present-final-annotation-navigationMapView
branch
3 times, most recently
from
bc90da8
to
372223b
Compare
Codecov Report
@@ Coverage Diff @@
## main #4253 +/- ##
==========================================
+ Coverage 61.04% 61.06% +0.02%
==========================================
Files 189 189
Lines 21179 21181 +2
==========================================
+ Hits 12928 12935 +7
+ Misses 8251 8246 -5
|
kried
force-pushed
the
jill/NAVIOS-678-present-final-annotation-navigationMapView
branch
from
372223b
to
9e29e97
Compare
kried
force-pushed
the
jill/NAVIOS-678-present-final-annotation-navigationMapView
branch
from
9e29e97
to
790cbad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes
NavigationMapView.addDestinationAnnotationandNavigationMapView.removeDestinationAnnotationpublic, adds a callback based on style loading, and changes the way identifiers are handled.