Changed swift code and podspec to use resource bundle #4519
Conversation
Co-authored-by: mapbox-ci <[email protected]>
* vk/NAVIOS-41-time-diff-callouts: fixed method for picking time diff callout coordinate; CHANGELOG updated
* vk/NAVIOS-908-cp-templates-fix: added completions to setting and popping to root CP templates; CHANGELOG updated
* vk/NAVIOS-1233-carplay-maneuver-color: fixed applying correct style type when generating maneuver arrow for carplay; CHANGELOG updated
….0 (mapbox#4483) (mapbox#4485) * [Snapshot] Update dependencies: Common SDK to 23.6.0, Maps 10.14.0, NN to 137.0. Co-authored-by: Nastassia Makaranka <[email protected]>
Co-authored-by: mapbox-ci <[email protected]>
There was a problem hiding this comment.
Hey, @Francisco-Costa98! Thanks for contributing! I see few NITs, but otherwise it should be good to go. And also, please retarget this PR to main branch instead. v2.14 is not planned to have patches, so this fix won't be available if merged there. If you are using 2.14 it is still recommended to update to the latest, there should be no effort on your side to do so.
| guard let resourceBundleURL = frameworkBundle.url( | ||
| forResource: "MapboxNavigationResources", withExtension: "bundle") | ||
| else { fatalError("MapboxNavigationResources.bundle not found!") } | ||
|
|
||
| guard let resourceBundle = Bundle(url: resourceBundleURL) | ||
| else { fatalError("Cannot access MySDK.bundle!") } | ||
|
|
||
| return resourceBundle |
There was a problem hiding this comment.
will fix - im fairly new to xcode dev, going to have a look at how to setup linting for stuff like this properly, do you have any recommendations?
Co-authored-by: Victor Kononov <[email protected]>
Thank you for the feedback - ill open it against main - although currently im locked into this specific version for my project due to also depending on the react native mapbox library, going try to see if i can upgrade that to the latest aswell with no issues |
Description
solves issue #4516
changed to use the non-deprecated
resource_bundlein the podspec file instead ofresources-> this fixes the multiple output commands produce Assets.Car error since the release of xcode 12---------- CHECKLIST ----------
bug,feature,new API(s),SEMVER-MAJOR,needs-backporting, etc.). - cant seem to be able to do this-->