Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cherry pick] Use camera options to calculate zoom for overview camera #4600

Merged
merged 2 commits into from
Feb 16, 2024

Conversation

kried
Copy link
Contributor

@kried kried commented Feb 16, 2024

Description

Cherry pick of #4593 into 2.18

@kried kried self-assigned this Feb 16, 2024
@kried kried requested a review from a team as a code owner February 16, 2024 12:35
@kried kried changed the base branch from main to release-v2.18 February 16, 2024 12:37
Copy link

codecov bot commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7f02db2) 60.58% compared to head (32336f9) 60.62%.
Report is 2 commits behind head on release-v2.18.

Impacted file tree graph

@@                Coverage Diff                @@
##           release-v2.18    #4600      +/-   ##
=================================================
+ Coverage          60.58%   60.62%   +0.03%     
=================================================
  Files                189      189              
  Lines              21249    21265      +16     
=================================================
+ Hits               12874    12892      +18     
+ Misses              8375     8373       -2     
Files Coverage Δ
...apboxNavigation/NavigationViewportDataSource.swift 92.06% <100.00%> (+0.27%) ⬆️

... and 1 file with indirect coverage changes

@kried kried force-pushed the cherry-pick-pr-4593 branch from 8eeb99e to 32336f9 Compare February 16, 2024 13:52
@kried kried merged commit 1e38063 into release-v2.18 Feb 16, 2024
18 checks passed
@kried kried deleted the cherry-pick-pr-4593 branch February 16, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants