Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CarPlay background maneuver card #4621

Merged
merged 5 commits into from
Apr 3, 2024
Merged

Conversation

chizhavko
Copy link
Contributor

@chizhavko chizhavko commented Apr 2, 2024

This PR introduce new logic related to configuration to set custom colors to CPMapTemplate.guidanceBackgroundColor using new delegate method:
CarPlayNavigationViewControllerDelegate.carPlayNavigationViewController(_:guidanceBackgroundColor:)

@chizhavko chizhavko requested a review from a team as a code owner April 2, 2024 15:04
@chizhavko chizhavko changed the title Fix carplay background maneuver card Fix CarPlay background maneuver card Apr 2, 2024
Copy link

codecov bot commented Apr 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 21 lines in your changes are missing coverage. Please review.

Project coverage is 60.51%. Comparing base (ac14229) to head (f47536f).

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4621      +/-   ##
==========================================
- Coverage   60.54%   60.51%   -0.03%     
==========================================
  Files         189      189              
  Lines       21297    21307      +10     
==========================================
  Hits        12894    12894              
- Misses       8403     8413      +10     
Files Coverage Δ
Sources/MapboxNavigation/CarPlayManager.swift 44.21% <0.00%> (-0.14%) ⬇️
...tion/CarPlayNavigationViewControllerDelegate.swift 0.00% <0.00%> (ø)
...rces/MapboxNavigation/CarPlayManagerDelegate.swift 2.91% <0.00%> (-0.16%) ⬇️
...oxNavigation/CarPlayNavigationViewController.swift 14.40% <0.00%> (+0.05%) ⬆️

@mapbox-github-ci-issues-public-1

API compatibility report for MapboxNavigation: 🔴

Protocol Requirement Change

  • Func CarPlayManagerDelegate.carPlayNavigationViewController(_:guidanceBackgroundColorFor:) has been added as a protocol requirement
  • Func CarPlayNavigationViewControllerDelegate.carPlayNavigationViewController(_:guidanceBackgroundColorFor:) has been added as a protocol requirement

@chizhavko chizhavko merged commit f2c0f49 into main Apr 3, 2024
21 checks passed
@chizhavko chizhavko deleted the fix-carplay-background-car branch April 3, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants