Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SSDK-666] Use circleci context in setup step #218

Merged
merged 4 commits into from
Apr 19, 2024
Merged

[SSDK-666] Use circleci context in setup step #218

merged 4 commits into from
Apr 19, 2024

Conversation

aokj4ck
Copy link
Contributor

@aokj4ck aokj4ck commented Apr 19, 2024 •
edited by jira bot
Loading

Description

Fixes SSDK-666, details in ticket

Checklist

  • [NA] Update CHANGELOG

@aokj4ck aokj4ck marked this pull request as ready for review April 19, 2024 16:01
@aokj4ck aokj4ck requested review from a team as code owners April 19, 2024 16:01
@aokj4ck aokj4ck enabled auto-merge (squash) April 19, 2024 16:05
billyjbryant
billyjbryant approved these changes Apr 19, 2024
View reviewed changes
Copy link
Member

@billyjbryant billyjbryant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming blank spaces are interpreted correctly by CircleCI?

LGTM :shipit:

@aokj4ck aokj4ck merged commit 038508e into main Apr 19, 2024
5 checks passed
@aokj4ck aokj4ck deleted the SSDK-666-clean-up-circleci branch April 19, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billyjbryant billyjbryant billyjbryant approved these changes

@mikeringrose mikeringrose mikeringrose approved these changes

@mapbox-danny mapbox-danny Awaiting requested review from mapbox-danny mapbox-danny is a code owner automatically assigned from mapbox/search-sdk

@ahmedaly16 ahmedaly16 Awaiting requested review from ahmedaly16 ahmedaly16 is a code owner automatically assigned from mapbox/search-sdk

@ThibaudLopez ThibaudLopez Awaiting requested review from ThibaudLopez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aokj4ck @mikeringrose @billyjbryant