Poi update working api ui merge #1024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…plication.isPlaying check for density slider in PrefabItemOptionsDrawer. Events are firing corectly, but map is not redrawing with POI changes correctly, may need to apply modified properties early.
…d to be brute force set to true.
… in Open(), thus allowing classes that derive from MapboxDataProperty to be passed, thus allowing for direct calls to EditorHelper.CheckForModifiedProperty<T>(SerializedProperty property, T targetObject, bool forceHasChanged = false), thus eliminating the need for bool updateAbstractMap = false. Refactored relevant drawer code to reflect this change; refactored relevant drawer code with correct change check structure.
…ate-working-api-ui-merge
…ate-working-api-ui-merge
…ate-working-api-ui-merge
…LayerPropertyRemoved instead of generic HasChanged = true set.
…ate-working-api-ui-merge
…apbox-unity-sdk into POI-update-working-api-ui-merge * 'POI-update-working-api-ui-merge' of github.com:mapbox/mapbox-unity-sdk: add default poi prefab and use it on new poi layers fix an issue where poi layer didn't create prefab modifier for name and latlng settings (#1028) Removed true argument from CheckForModifiedProperty.
| @@ -0,0 +1,214 @@ | |||
| %YAML 1.1 | |||
There was a problem hiding this comment.
Why did the prefab change? can we remove this change?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
Example: Closes #832. Relates to #832.
Description of changes
Your text here!
QA checklists
<summary>description as well as description of parameters.Reviewers
Tag your reviewer(s). Choose wisely.