Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reloadscript serialization playmode fix #1213

Conversation

greglemonmapbox
Copy link
Contributor

@greglemonmapbox greglemonmapbox commented Jan 3, 2019

Description of changes

Fixes issue w/ broken map serialization during script reloads by destroying and redrawing map.

QA checklists

  • Add relevant code comments. Every API class and method should have <summary> description as well as description of parameters.
  • Add tests for new/changed/updated classes and methods!!!
  • Check out conventions in CONTRIBUTING.md.
  • Check out conventions in CODING-STYLE.md
  • Update the changelog
  • Update documentation.

Reviewers

Tag your reviewer(s). Choose wisely.

abhishektrip and others added 2 commits January 2, 2019 15:04
…I -> EditorHelper.OnScriptsReloaded; removed refs to AbstractMap.ReEnablePreview. Removed reload-relevant debug messages.
@abhishektrip abhishektrip changed the base branch from release/v2.0.1 to reloadscript-serialization-fix January 3, 2019 00:08
@abhishektrip abhishektrip merged commit 82c7ec5 into reloadscript-serialization-fix Jan 3, 2019
@abhishektrip abhishektrip deleted the reloadscript-serialization-playmode-fix branch October 15, 2019 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants