Fix longitudes outside of [-180,180] range #194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mourner
requested changes
Dec 24, 2021
| @@ -387,7 +387,7 @@ function getClusterProperties(cluster) { | |||
|
|
|||
| // longitude/latitude to spherical mercator in [0..1] range | |||
| function lngX(lng) { | |||
| return lng / 360 + 0.5; | |||
| return lng / 360 + 0.5 + (lng > 180 || lng < -180 ? -Math.sign(lng) : 0); | |||
There was a problem hiding this comment.
A slightly simpler / more reliable way to wrap the value:
Suggested change
| return lng / 360 + 0.5 + (lng > 180 || lng < -180 ? -Math.sign(lng) : 0); | |
| return ((lng / 360 + 0.5) % 1 + 1) % 1; |
There was a problem hiding this comment.
Thanks for the tip on the alternative math. I tested it and unfortunately, it breaks the tests.
With the suggested approach, the returned values from lngX are different from the values from the first solution at their ~14-15 decimal digit, which causes the tests to fail. So I kept the original solution for now.
I've also added a test for this change in 99c877f.
There was a problem hiding this comment.
@mourner just a quick follow-up on this PR to see if there are any other changes you'd like me to include. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not necessarily an issue with supercluster (assuming it expects all longitudes to be within the [-180, 180] range), but it causes issues with
maplibre-glandmapbox-gl.For example, a point with coordinates [-181, 0] renders fine in a non-cluster mode in the two mentioned libraries, but it doesn't render in a clustered geojson source. Here's an example showing this issue: https://codepen.io/kaveh/pen/mdBqrYq. The red layer is for non-clustered points (shows 2 rendered points) and green is for clustered (shows only 1).
I could fix my coordinates before adding them to source in those libraries, but I thought if the same data works in non-clustered mode, it should work with clustered mode too and that's why I submitted the fix here.