Pre-clean each ring of polygons to fix the bow tie problem #769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flippmoke
reviewed
Jun 28, 2019
| @@ -269,7 +269,7 @@ drawvec clean_or_clip_poly(drawvec &geom, int z, int buffer, bool clip) { | |||
|
|
|||
| mapbox::geometry::multi_polygon<long long> result; | |||
| try { | |||
| wagyu.execute(mapbox::geometry::wagyu::clip_type_union, result, mapbox::geometry::wagyu::fill_type_positive, mapbox::geometry::wagyu::fill_type_positive); | |||
| wagyu.execute(mapbox::geometry::wagyu::clip_type_union, result, even_odd ? mapbox::geometry::wagyu::fill_type_even_odd : mapbox::geometry::wagyu::fill_type_positive, even_odd ? mapbox::geometry::wagyu::fill_type_even_odd : mapbox::geometry::wagyu::fill_type_positive); | |||
There was a problem hiding this comment.
The second fill option is only needed to change if you are using "clip" polygon types with add_ring, I believe you are only using subject polygon types so you can probably just always leave the 2nd option as positive?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.