fix: interpolate invalid GPS timestamps #696
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements to the
mapillary_tools/geotag/gpmf_parser.py
file, focusing on enhancing GPS timestamp handling and code organization. The most important changes include reordering imports, adding error handling for GPS timestamp conversion, implementing a function to backfill GPS timestamps, and modifying the extraction of points from samples to use the new backfill function.Enhancements to GPS timestamp handling:
gps5_from_stream
function to ensure robustness when converting GPS timestamps._backfill_gps_timestamps
to fill in missing GPS timestamps based on available data points._extract_points_from_samples
function to use the_backfill_gps_timestamps
function, ensuring that GPS timestamps are backfilled both forward and backward from the first available timestamp.Code organization improvements:
datetime
import to the correct position.