Skip to content

Commit

Permalink
MINOR: [C++][ORC][CMake] Fix ORC CMake args to use LZ4_STATIC_LIB (ap…
Browse files Browse the repository at this point in the history
…ache#41632)

### Rationale for this change

In the ORC_CMAKE_ARGS, we use `LZ4_STATIC_LIBRARY` but the Apache ORC library expects [`LZ4_STATIC_LIB`](https://github.com/apache/orc/blob/08aaebc371927e6bb9a0f19c7cc90478200e3b6f/cmake_modules/ThirdpartyToolchain.cmake#L313)

### What changes are included in this PR?

Switch `LZ4_STATIC_LIBRARY` to `LZ4_STATIC_LIB` in the ORC_CMAKE_ARGS.

### Are these changes tested?

Pass CIs.

### Are there any user-facing changes?

No.

Authored-by: Gang Wu <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
  • Loading branch information
wgtmac authored May 13, 2024
1 parent 0e9896d commit 2552c26
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion cpp/cmake_modules/ThirdpartyToolchain.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -4522,7 +4522,7 @@ macro(build_orc)
"-DSNAPPY_HOME=${ORC_SNAPPY_ROOT}"
"-DSNAPPY_LIBRARY=$<TARGET_FILE:${Snappy_TARGET}>"
"-DLZ4_LIBRARY=$<TARGET_FILE:LZ4::lz4>"
"-DLZ4_STATIC_LIBRARY=$<TARGET_FILE:LZ4::lz4>"
"-DLZ4_STATIC_LIB=$<TARGET_FILE:LZ4::lz4>"
"-DLZ4_INCLUDE_DIR=${ORC_LZ4_ROOT}/include"
"-DSNAPPY_INCLUDE_DIR=${ORC_SNAPPY_INCLUDE_DIR}"
"-DZSTD_HOME=${ORC_ZSTD_ROOT}"
Expand Down

0 comments on commit 2552c26

Please sign in to comment.