Skip to content

Commit

Permalink
trying to fix the ci build
Browse files Browse the repository at this point in the history
  • Loading branch information
mapleFU committed Jun 10, 2024
1 parent 057b542 commit 34a4c28
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
6 changes: 3 additions & 3 deletions cpp/src/parquet/bloom_filter_reader_writer_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ TEST(BloomFilterBuilderTest, BasicRoundTrip) {
bloom_filter_options.ndv = 100;
properties_builder.enable_bloom_filter_options(bloom_filter_options, "c1");
auto writer_properties = properties_builder.build();
auto builder = BloomFilterBuilder::Make(&schema, writer_properties.get());
auto builder = internal::BloomFilterBuilder::Make(&schema, writer_properties.get());

auto append_values_to_bloom_filter = [&](const std::vector<uint64_t>& insert_hashes) {
builder->AppendRowGroup();
Expand Down Expand Up @@ -164,7 +164,7 @@ TEST(BloomFilterBuilderTest, InvalidOperations) {
properties_builder.enable_bloom_filter_options(bloom_filter_options, "c1");
properties_builder.enable_bloom_filter_options(bloom_filter_options, "c2");
auto properties = properties_builder.build();
auto builder = BloomFilterBuilder::Make(&schema, properties.get());
auto builder = internal::BloomFilterBuilder::Make(&schema, properties.get());
// AppendRowGroup() is not called and expect throw.
EXPECT_THROW_THAT(
[&]() { builder->GetOrCreateBloomFilter(0); }, ParquetException,
Expand Down Expand Up @@ -208,7 +208,7 @@ TEST(BloomFilterBuilderTest, GetOrCreate) {
properties_builder.enable_bloom_filter_options(bloom_filter_options, "c1");
properties_builder.enable_bloom_filter_options(bloom_filter_options, "c2");
auto properties = properties_builder.build();
auto builder = BloomFilterBuilder::Make(&schema, properties.get());
auto builder = internal::BloomFilterBuilder::Make(&schema, properties.get());
// AppendRowGroup() is not called and expect throw.
ASSERT_THROW(builder->GetOrCreateBloomFilter(0), ParquetException);

Expand Down
3 changes: 2 additions & 1 deletion cpp/src/parquet/column_writer_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1749,7 +1749,8 @@ TestBloomFilterWriter<TestType>::BuildWriterWithBloomFilter(
ColumnChunkMetaDataBuilder::Make(this->writer_properties_, this->descr_);
std::unique_ptr<PageWriter> pager = PageWriter::Open(
this->sink_, column_properties.compression(), this->metadata_.get());
builder_ = BloomFilterBuilder::Make(&this->schema_, this->writer_properties_.get());
builder_ =
internal::BloomFilterBuilder::Make(&this->schema_, this->writer_properties_.get());
// Initial RowGroup
builder_->AppendRowGroup();
bloom_filter_ = builder_->GetOrCreateBloomFilter(0);
Expand Down

0 comments on commit 34a4c28

Please sign in to comment.