Skip to content

Commit

Permalink
apacheGH-40331: [C++][CMake] Add missing glog::glog dependency to arr…
Browse files Browse the repository at this point in the history
…ow_util (apache#40332)

### Rationale for this change

`cpp/src/arrow/util/logging.cc` may use glog. So `arrow_util` OBJECT target(s) must depend on `glog::glog`.

### What changes are included in this PR?

Add missing `glog::glog` dependency to `${ARROW_UTIL_TARGETS}`.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.
* GitHub Issue: apache#40331

Authored-by: Sutou Kouhei <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
  • Loading branch information
kou authored Mar 4, 2024
1 parent 6406676 commit 70bb0fb
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions cpp/src/arrow/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -563,6 +563,11 @@ if(ARROW_USE_BOOST)
target_link_libraries(${ARROW_UTIL_TARGET} PRIVATE Boost::headers)
endforeach()
endif()
if(ARROW_USE_GLOG)
foreach(ARROW_UTIL_TARGET ${ARROW_UTIL_TARGETS})
target_link_libraries(${ARROW_UTIL_TARGET} PRIVATE glog::glog)
endforeach()
endif()
if(ARROW_USE_XSIMD)
foreach(ARROW_UTIL_TARGET ${ARROW_UTIL_TARGETS})
target_link_libraries(${ARROW_UTIL_TARGET} PRIVATE ${ARROW_XSIMD})
Expand Down

0 comments on commit 70bb0fb

Please sign in to comment.