Skip to content

Commit

Permalink
address comment
Browse files Browse the repository at this point in the history
  • Loading branch information
mapleFU committed May 7, 2024
1 parent ddd0cde commit 7daee1c
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions cpp/src/parquet/encoding.h
Original file line number Diff line number Diff line change
Expand Up @@ -256,9 +256,10 @@ class Decoder {
// Sets the data for a new page. This will be called multiple times on the same
// decoder and should reset all internal state.
//
// In current implementations, `num_values` is the `num_values` field in the
// data page header, which may greater than the number of values in the data
// buffer.
// `num_values` comes from the data page header, and may be greater than the number of
// physical values in the data buffer if there are some omitted (null) values.
// `len`, on the other hand, is the size in bytes of the data buffer and
// directly relates to the number of physical values.
virtual void SetData(int num_values, const uint8_t* data, int len) = 0;

// Returns the number of values left (for the last call to SetData()). This is
Expand Down

0 comments on commit 7daee1c

Please sign in to comment.