apacheGH-38861: [C++] Add missing "-framework Security" to Libs.priva…

…te in arrow.pc (apache#38869) ### Rationale for this change It's required only when: * We use bundled aws-sdk-cpp. * We use static library for Apache Arrow C++. Because bundled aws-sdk-cpp uses Security framework. ### What changes are included in this PR? Add `-framework Security` to `Libs.private` only on the condition. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * Closes: apache#38861 Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Jacob Wujciak-Jens <[email protected]>
mapleFU · Nov 25, 2023 · eb5de18 · eb5de18
1 parent 7da7895
commit eb5de18
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/cpp/cmake_modules/ThirdpartyToolchain.cmake b/cpp/cmake_modules/ThirdpartyToolchain.cmake
@@ -5063,6 +5063,9 @@ if(ARROW_S3)
         string(APPEND ARROW_PC_REQUIRES_PRIVATE " libcurl")
       endif()
       string(APPEND ARROW_PC_REQUIRES_PRIVATE " openssl")
+      if(APPLE)
+        string(APPEND ARROW_PC_LIBS_PRIVATE " -framework Security")
+      endif()
     endif()
   endif()
 

diff --git a/cpp/src/arrow/CMakeLists.txt b/cpp/src/arrow/CMakeLists.txt
@@ -598,7 +598,7 @@ if(ARROW_BUILD_BUNDLED_DEPENDENCIES)
                       IMPORTED_LOCATION)
   install(FILES ${arrow_bundled_dependencies_path} ${INSTALL_IS_OPTIONAL}
           DESTINATION ${CMAKE_INSTALL_LIBDIR})
-  string(APPEND ARROW_PC_LIBS_PRIVATE " -larrow_bundled_dependencies")
+  string(PREPEND ARROW_PC_LIBS_PRIVATE " -larrow_bundled_dependencies")
   list(INSERT ARROW_STATIC_INSTALL_INTERFACE_LIBS 0 "Arrow::arrow_bundled_dependencies")
 endif()