-
-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Kotlin instead of Groovy for Android build configuration #2902
Conversation
@louwers have fixed the error related to checkstyle. |
@adrian-cojocaru Could you check if the Vulkan validation layers still work with this? |
Vulkan validation doesn't seem to be present in the build (the download never starts?). |
@adrian-cojocaru How did you enable it before? |
It's enabled by default for |
@adrian-cojocaru It's present in the build at line no. 9 at 'platform/android/MapLibreAndroid/build.gradle.kts'
|
@louwers , @adrian-cojocaru I have made some changes for Vulkan validation, Plz check if it's working now. |
@louwers , @adrian-cojocaru it has passed all the checks, please confirm if there is still an issue in Vulkan. |
@kaushalbx From a quick look it seems that the |
@adrian-cojocaru now I am able to see unzipped file at 'platform/android/MapLibreAndroid/src/vulkanDebug/jniLibs'. This is what we are expecting? |
@adrian-cojocaru when i ran the command gradlew :MapLibreAndroid:unzip it downloaded the zip file at 'platform/android/MapLibreAndroid/android-binaries-1.3.290.0.zip' and unzipped it at 'platform/android/MapLibreAndroid/src/vulkanDebug/jniLibs/android-binaries-1.3.290.0'. |
@louwers please run the checks. |
The files should be in |
platform/android/buildSrc/src/main/kotlin/maplibre.download-vulkan-validation.gradle.kts
Show resolved
Hide resolved
platform/android/buildSrc/src/main/kotlin/maplibre.download-vulkan-validation.gradle.kts
Show resolved
Hide resolved
platform/android/buildSrc/src/main/kotlin/maplibre.download-vulkan-validation.gradle.kts
Show resolved
Hide resolved
Thanks for addressing the final comments @kaushalbx! The Vulkan render tests started failing on CI at least, @adrian-cojocaru do you think this is an issue with the build config? |
…on-logging, commons-collections
The Vulkan render tests failed before, I hope they pass now... Thanks for the reviews @adrian-cojocaru and @westnordost! |
Groovy to kotlin dsl migration, solving issue #2699