Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change parameters.currentLayer to index instead of layerIndex #2956

Merged

Conversation

alexcristici
Copy link
Collaborator

@alexcristici alexcristici commented Oct 22, 2024

In order to compare the parameters.currentLayer correctly with parameters.opaquePassCutoff we need to compute the parameters.currentLayer every frame instead of using the layerGroup.getLayerIndex().

I also removed drawable.getLayerIndex().

@alexcristici alexcristici self-assigned this Oct 22, 2024
@alexcristici alexcristici linked an issue Oct 22, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Oct 22, 2024

Bloaty Results (iOS) 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  -0.0%    -248  [ = ]       0    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results-ios/pr-2956-compared-to-main.txt

Copy link

github-actions bot commented Oct 22, 2024

Bloaty Results 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  -0.0% -1.92Ki  -0.0% -1.14Ki    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-2956-compared-to-main.txt

Compared to d387090 (legacy)

    FILE SIZE        VM SIZE    
 --------------  -------------- 
   +30% +34.5Mi  +432% +25.8Mi    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-2956-compared-to-legacy.txt

Copy link

github-actions bot commented Oct 22, 2024

Benchmark Results ⚡

Benchmark                                                     Time             CPU      Time Old      Time New       CPU Old       CPU New
------------------------------------------------------------------------------------------------------------------------------------------
OVERALL_GEOMEAN                                            -0.0120         -0.0119             0             0             0             0

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/benchmark-results/pr-2956-compared-to-main.txt

@louwers louwers changed the title Changed parameters.currentLayer to index instead of layerIndex Change parameters.currentLayer to index instead of layerIndex Oct 29, 2024
@louwers louwers merged commit e95e0e1 into maplibre:main Oct 29, 2024
39 checks passed
@alexcristici alexcristici deleted the opaque-cutoff-compared-to-right-layer-index branch October 29, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

fill-extrude layer is drawn above the next-above symbol layer
3 participants