-
-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update react and react-native #49
Update react and react-native #49
Conversation
@sarahsporck I pushed a few minor changes and also enabled CI checks (don't know why those weren't there before TBH; my bad haha). Everything looks good to me on iOS, but Android appears to get stuck on the React Native Flipper integration, which is enabled by default. I stumbled across this issue on GitHub: facebook/react-native#36091. It seems like the initial issue was that
|
Should be fixed. But checks have disappeared again o.o |
I think it's a GitHub security setting that requires approval to run actions for first-time contributors. Fixed the lint issue and re-running now. |
Funny enough, while it works great locally, I still can't run assemble on the Android example. Nor am I really sure why this check exists as part of the CI nor why it works when a run Not worth any more fuss over though; I'll merge this as soon as the iOS pipeline succeeds. Thanks for slogging through this! |
Description
Fixes #7
Checklist
yarn lint:fix
in the root folderyarn test
in the root folderyarn generate
in the root folderCHANGELOG.md
index.d.ts
)/example
)