Use node 16.x #776
Use node 16.x #776
Conversation
It required converting mocha tests code into async since [@wdio/sync is deprecated](https://webdriver.io/docs/sync-vs-async/) starting with node v16. It removed the dependency on fibers and on [node-gyp + python](https:// webdriver.io/docs/sync-vs-async/#common-issues-in-sync-mode) indirectly though which is a great thing. Also moved away from node-sass to sass since [node-sass is deprecated] (https://sass-lang.com/blog/libsass-is-deprecated).
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c77d8f6:
|
|
Was looking into why test/standalone-chrome keeps failing all the time and apparently there might be a problem with sandbox + /dev/shm size for Docker image. Will share /dev/shm volume with host to mitigate. Tried to use runner machine instead of Docker images with headless mode, but Firefox does not support WebGL in headless mode and two tests were failing as there was no .mapboxgl-canvas element. Need to investigate it some time later. |
|
Wow, this great @propheel, thanks a bunch and welcome to Maputnik! 🎉
👍 especially the dependency on fibers caused much annoyance. |
|
Thank you @pathmapper ! This is actually my first contribution to OSS in my life. I didn't expect such great experience! 😄 Hope that it will stay along with more PRs that will come 😉 |
It required converting mocha tests code into async since @wdio/sync is deprecated starting with node v16. It removed the dependency on fibers and on node-gyp + python indirectly though which is a great thing.
Also moved away from node-sass to sass since node-sass is deprecated which addresses #762 .
It is also a beginning of Maputnik upgrade #775
Feel free to share comments.