-
-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added validate function to PgConfig and invoked it in finalize and pool initialization #1546
Merged
Merged
Changes from 6 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
55289af
Added validate function to PgConfig and invoked it in finalize and po…
Saru2003 5a2dbbd
Fix formatting issues and validate pool size
Saru2003 83cb044
Fix PgError import
Saru2003 14add38
Fix PgError import and Added ValidationError variant
Saru2003 d9af9e6
Rearrange imports in config.rs
Saru2003 d847bee
Rearranged use statements in config.rs for clarity and convention.
Saru2003 5f69d95
Refactor config validation and error handling
Saru2003 36911fc
Fixing lint issue in updated validate return
Saru2003 7ca992a
Fixing lint issue in updated validate return, v2
Saru2003 fd8d60b
Fixing lint issue in updated validate return, v3
Saru2003 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -69,4 +69,7 @@ pub enum PgError { | |
|
||
#[error(r#"Unable to get tile {2:#} with {:?} params from {1}: {0}"#, query_to_json(.3.as_ref()))] | ||
GetTileWithQueryError(#[source] TokioPgError, String, TileCoord, Option<UrlQuery>), | ||
|
||
#[error("Validation error: {0}")] | ||
ValidationError(String), | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Lets call this |
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we need to validate it in so many places - here, in the pool, and in finalize? I don't remember for sure which codepath always executes, but we should probably limit it to just one. Probably finalize? Please check. Thx!