Do not update tiles with same hash #1559
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -216,7 +216,7 @@ impl Mbtiles { | |||
| ), | |||
| Some(format!( | |||
| " | |||
| INSERT {on_duplicate} INTO images (tile_id, tile_data) | |||
| INSERT OR IGNORE INTO images (tile_id, tile_data) | |||
There was a problem hiding this comment.
This PR is missing a lot of context. Describing the changes you want/need to make goes a long way..
- What was your original issue?
Could you attach a testcase to avoid regressions? - Why does changing just this insert statement to
CopyDuplicateMode::Ignoresolve this? Why should this behave differently forimages?
|
@pka hi, i'm not sure what you tried to do here - in the copying, it is already possible to set how override will be done with a CLI flag |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.