-
-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic support for systemd #761
Conversation
thx @sharkAndshark , can you think of a way to automate testing of the debian packages? Perhaps run some sort of More specifically about this PR - Martin is clearly a service, so integrating it with a service infrastructure makes perfect sense, but it does not really make any sense without some configuration - so should it be disabled by default? Not certain what the best options would be. |
Hi @nyurik. Something we should consider of per your comment: testHow and what to test a .deb file in our CI? There are some references I'm still researching on. the behaviors of martin as a service
|
Sorry, my mistake - I just realized you already do that in |
e06a336
to
c264099
Compare
Hi @nyurik :) just package-deb
sudo dpkg -i target/debian/martin.deb
just start Call martin directilymartin postgres://postgres:postgres@localhost:5411/db We have made a test about this: Call martin as service# enable martin automatically start
systemctl enable martin
vim /usr/local/etc/martin/config.yaml
...
systemctl start martin
systemctl status martin Do you think we need a test for calling marin as a service? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, thanks!
P.S. We could add a simple check if a specific file exists in CI after debian package install - up to you |
No description provided.