Improve auto-publish usability #795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* on `--save-config`, only save configured `auto_publish` settings * alias `from_schemas` as `from_schema` * add integration testing for `auto_publish` * if integration test DB preloading fails, try to clean up the test DB * A few more info traces
6 tasks
upsicleclown
approved these changes
Aug 3, 2023
Comment on lines
+11
to
+19
| -- INSERT INTO autodetect.auto_table | ||
| -- SELECT generate_series(1, 3) as id, | ||
| -- (random() * 100000)::int as feat_id, | ||
| -- (ST_DUMP(ST_GENERATEPOINTS(st_transform(st_tileenvelope(18, 235085, 122323), 4326), 3))).geom; | ||
| -- INSERT INTO autodetect.auto_table | ||
| -- SELECT generate_series(4, 30) as id, | ||
| -- (random() * 100000)::int as feat_id, | ||
| -- (ST_DUMP(ST_GENERATEPOINTS(st_transform(st_tileenvelope(0, 0, 0), 4326), 27))).geom; | ||
|
|
There was a problem hiding this comment.
Nit: Is this comment still needed?
There was a problem hiding this comment.
Yes, all other tests include the code how they were initially generated. Makes it easier to regen if needed, plus it documents ranges
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--save-config, only save configuredauto_publishsettingsfrom_schemasasfrom_schemaauto_publishThis change should benefit testing of the #790 cc: @Binabh