Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add integrity and global hash check to validation #851

Merged
merged 2 commits into from
Aug 31, 2023
Merged

Add integrity and global hash check to validation #851

merged 2 commits into from
Aug 31, 2023

Conversation

upsicleclown
Copy link
Collaborator

No description provided.

nyurik
nyurik reviewed Aug 30, 2023
View reviewed changes
Copy link
Member

@nyurik nyurik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! see inline, but its nearly done

martin-mbtiles/src/mbtiles.rs Outdated Show resolved Hide resolved
martin-mbtiles/src/mbtiles.rs Outdated Show resolved Hide resolved
martin-mbtiles/src/mbtiles.rs Outdated
.fetch_one(&mut *conn)
.await?
.get::<String, _>(0),
IntegrityCheck::Quick => query("PRAGMA integrity_check;")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
IntegrityCheck::Quick => query("PRAGMA integrity_check;")
IntegrityCheck::Quick => query("PRAGMA quick_check;")

martin-mbtiles/src/mbtiles.rs Outdated Show resolved Hide resolved
martin-mbtiles/src/mbtiles.rs Outdated Show resolved Hide resolved
martin-mbtiles/src/mbtiles.rs Outdated Show resolved Hide resolved
martin-mbtiles/src/mbtiles.rs Outdated Show resolved Hide resolved
martin-mbtiles/src/mbtiles.rs Outdated Show resolved Hide resolved
martin-mbtiles/src/mbtiles.rs Outdated Show resolved Hide resolved
martin-mbtiles/src/tile_copier.rs Outdated Show resolved Hide resolved
@upsicleclown upsicleclown marked this pull request as ready for review August 31, 2023 01:58
@upsicleclown upsicleclown self-assigned this Aug 31, 2023
nyurik
nyurik reviewed Aug 31, 2023
View reviewed changes
Copy link
Member

@nyurik nyurik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost there, a few tiny fixes

martin-mbtiles/src/mbtiles.rs Outdated Show resolved Hide resolved
martin-mbtiles/src/errors.rs Outdated Show resolved Hide resolved
martin-mbtiles/src/mbtiles.rs Outdated Show resolved Hide resolved
nyurik
nyurik approved these changes Aug 31, 2023
View reviewed changes
Copy link
Member

@nyurik nyurik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, feel free to merge when ready. Thanks!

@upsicleclown upsicleclown enabled auto-merge (squash) August 31, 2023 03:29
@upsicleclown upsicleclown merged commit 875a942 into maplibre:main Aug 31, 2023
16 checks passed
@upsicleclown upsicleclown deleted the add-to-mbtiles-validation branch August 31, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nyurik nyurik nyurik approved these changes

Assignees

@upsicleclown upsicleclown

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@upsicleclown @nyurik