Expand Clusters on Tap #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Same as the other PR; code looks good and I'll merge after some quick sanity testing in our apps :) |
ianthetechie
approved these changes
Jun 12, 2024
| }) | ||
| .expandClustersOnTapping(clusteredLayers: [ClusterLayer( | ||
| layerIdentifier: "simple-circles-clusters", | ||
| sourceIdentifier: "points" |
There was a problem hiding this comment.
It would be be nice if we can find a way to pass in a source DSL type directly rather than just strings at some point. A string definitely has to be an option though (you may not control all layers of interest via the DSL), so this isn't a blocker.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an expandClustersOnTapping viewModifier. When used, if a user taps a cluster feature, the expand function of its source is used to choose a new zoom level.
I chose a slightly different implementation than discussed. Instead of taking a toggle bool, it takes an array of ClusterLayer which describes which layers/sources are the cluster layers. The reason is that the
visibleFeaturesfunction does not return which layer or source was tapped, so if we do not require users to provide which layers and sources to check, our implementation would instead need to go through all sources and layers of the map until it finds where this tapped cluster feature originated from. By making users provide us with the potential layers/sources, this makes the process more efficient and allows for filtering if required.