Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make release process more sane #77

Merged
merged 1 commit into from
Mar 18, 2025
+2 −5
Merged

Make release process more sane #77

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions .github/workflows/release.yml
View file
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
name: Release

on:
push:
branches:
- main
workflow_dispatch:
inputs:
bump_version_scheme:
@@ -17,11 +14,11 @@ on:
- 'major'

jobs:
release-on-push:
release:
runs-on: ubuntu-latest
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
steps:
- uses: rymndhng/[email protected]
with:
bump_version_scheme: ${{ github.event_name == 'push' && github.ref == 'refs/heads/main' && 'patch' || inputs.bump_version_scheme }}
bump_version_scheme: ${{ inputs.bump_version_scheme }}

Unchanged files with check annotations Beta

View file
Sources/MapLibreSwiftUI/MapViewCoordinator.swift
layer is MLNSymbolStyleLayer
}
for layerSpec in parent.userLayers {

Check warning on line 278 in Sources/MapLibreSwiftUI/MapViewCoordinator.swift

GitHub Actions / platform=iOS Simulator,name=iPhone 16,OS=18.1 

main actor-isolated property 'userLayers' can not be referenced from a nonisolated context; this is an error in the Swift 6 language mode
// DISCUSS: What preventions should we try to put in place against the user accidentally adding the same layer twice?
let newLayer = layerSpec.makeStyleLayer(style: mglStyle).makeMLNStyleLayer()
MainActor.assumeIsolated {
// regionIsChangingWith is not called for the final update, so we need to call updateViewProxy
// in both modes here.
updateViewProxy(mapView: mapView, reason: reason)

Check warning on line 384 in Sources/MapLibreSwiftUI/MapViewCoordinator.swift

GitHub Actions / platform=iOS Simulator,name=iPhone 16,OS=18.1 

sending 'self' risks causing data races; this is an error in the Swift 6 language mode
guard !suppressCameraUpdatePropagation else {
return